This repository has been archived by the owner on Mar 17, 2023. It is now read-only.
far from perfect... #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… updated dependancies for each file
…d); minor import errors corrected
…than tagged image in mm
…arated ReportingUtil tool
…deleted and replaced by storing metadata in different managers (such as acquisition manager, snaplive manager etc.)
…bject. There is a snapLiveManager object for this job
… rather than tagged image in mm" This reverts commit 70ac2e1.
…ut a separated ReportingUtil tool" This reverts commit 4afe9c1.
… is now deleted and replaced by storing metadata in different managers (such as acquisition manager, snaplive manager etc.)" This reverts commit 9201b92.
…ions from different parts of mm2
|
sorry there are 3 reverts in the middle of commits. Just because i found by replacing the file, git is not capable to identify where is exactly changed. So i reverted them and changed them line by line. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, this is my fast update of mm for Icy to mm2 for Icy. But i only ensure basic things work (such as live, snap etc..). To my knowledge, the multi-D acq does not work (can not test with our microscope, because i can not launch Icy from IntelliJ in windows, however i can launch Icy in mac/ubuntu without any error)
All the things that i don't know how to replace, i commented the line and added a TODO tag. (There are quite some of them..)
There is also some "compilation error" in MMMainframe identified by IntelliJ. But them do not block the launching. It requires awt dialog/image, nd i think Icy's GUIs didn't extends them?
Please feel free to ask me if you think i can ameliorate any part of the code.